Fix blank page in X in-app browser#21
Merged
Merged
Conversation
The previous fix (252da93) caught errors from storage method calls (setItem/getItem), but X's in-app browser blocks the property access itself — `window.localStorage` throws SecurityError before safeStorage() runs. Move the property access inside the try/catch by accepting a type string instead of a storage object. Also wrap the inline theme script's localStorage call in try/catch. Reproduced and verified with Playwright: simulating blocked storage property access, the page goes from blank to fully rendered. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setItem/getItem), but X's in-app browser blocks the property access itself —window.localStoragethrowsSecurityErrorbeforesafeStorage()even runssafeStorage()now takes a type string ('local'/'session') and accesses the storage property inside its own try/catchlocalStoragecall in try/catchRoot cause
When the module crashes,
main.jsxcan't import it,createRoot().render()never runs → blank page.Test plan
window.localStorageproperty access🤖 Generated with Claude Code